Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nolintlint linter #5508

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • It flags unused nolint directive comments

Description of the changes

  • Add linter and remove ineffective nolint directives

How was this change tested?

  • make lint

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner June 2, 2024 22:37
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Jun 2, 2024
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (b38d2f9) to head (f0f6bf1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5508   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files         327      327           
  Lines       16012    16012           
=======================================
  Hits        15401    15401           
  Misses        436      436           
  Partials      175      175           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.43% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.43% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7-v1 18.88% <ø> (ø)
elasticsearch-8-v1 19.08% <ø> (ø)
elasticsearch-8-v2 19.08% <ø> (+0.01%) ⬆️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.53% <ø> (ø)
kafka 9.78% <ø> (ø)
opensearch-1-v1 18.92% <ø> (ø)
opensearch-2-v1 18.92% <ø> (-0.02%) ⬇️
opensearch-2-v2 18.94% <ø> (ø)
unittests 93.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@albertteoh albertteoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yurishkuro yurishkuro merged commit fd1b39e into jaegertracing:main Jun 3, 2024
40 of 41 checks passed
@yurishkuro yurishkuro deleted the add-nolintlint branch June 3, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants