Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/golangci/golangci-lint from 1.55.2 to 1.59.1 and fix linter errors #5579

Merged
merged 9 commits into from
Jun 12, 2024

Conversation

FlamingSaint
Copy link
Member

@FlamingSaint FlamingSaint commented Jun 12, 2024

Which problem is this PR solving?

Description of the changes

  • fix lint errors

How was this change tested?

  • make lint make test

Checklist

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from a team as a code owner June 12, 2024 02:56
FlamingSaint and others added 2 commits June 12, 2024 08:28
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (965c538) to head (b2f9b02).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5579      +/-   ##
==========================================
+ Coverage   96.20%   96.21%   +0.01%     
==========================================
  Files         327      327              
  Lines       16006    16006              
==========================================
+ Hits        15398    15400       +2     
+ Misses        432      431       -1     
+ Partials      176      175       -1     
Flag Coverage Δ
badger_v1 8.05% <9.09%> (ø)
badger_v2 1.93% <0.00%> (ø)
cassandra-3.x-v1 16.45% <9.09%> (ø)
cassandra-3.x-v2 1.85% <0.00%> (ø)
cassandra-4.x-v1 16.45% <9.09%> (ø)
cassandra-4.x-v2 1.85% <0.00%> (ø)
elasticsearch-7.x-v1 18.89% <27.27%> (ø)
elasticsearch-8.x-v1 19.09% <27.27%> (ø)
elasticsearch-8.x-v2 19.09% <27.27%> (+0.01%) ⬆️
grpc_v1 9.48% <0.00%> (ø)
grpc_v2 7.53% <0.00%> (ø)
kafka 9.77% <0.00%> (ø)
opensearch-1.x-v1 18.93% <27.27%> (-0.02%) ⬇️
opensearch-2.x-v1 18.94% <27.27%> (+0.01%) ⬆️
opensearch-2.x-v2 18.94% <27.27%> (+0.01%) ⬆️
unittests 94.08% <95.23%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
renovate.json Outdated Show resolved Hide resolved
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
pkg/tenancy/grpc.go Outdated Show resolved Hide resolved
FlamingSaint and others added 2 commits June 12, 2024 09:16
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
Copy link
Member

I modified the hasher test a bit. Also, we're getting warnings from the new linter:

WARN [config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`.
WARN [config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`.
WARN [config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`.
WARN [config_reader] The configuration option `linters.gosimple.go` is deprecated, please use global `run.go`.

@yurishkuro yurishkuro changed the title Fix errors after dependabot upgrade Bump github.com/golangci/golangci-lint from 1.55.2 to 1.59.1 and fix linter errors Jun 12, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) June 12, 2024 04:42
@yurishkuro yurishkuro merged commit 0e7aaec into jaegertracing:main Jun 12, 2024
40 checks passed
@FlamingSaint FlamingSaint deleted the lint branch June 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants