Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify configs organization #5690

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jun 30, 2024

Description of the changes

  • Move memstore config from pkg/memory to plugin/storage/memory, as the separation was unnecessary
  • Simplify imports in the extension

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.40%. Comparing base (722755e) to head (86bd815).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5690      +/-   ##
==========================================
+ Coverage   96.38%   96.40%   +0.01%     
==========================================
  Files         334      334              
  Lines       16141    16141              
==========================================
+ Hits        15558    15560       +2     
+ Misses        405      404       -1     
+ Partials      178      177       -1     
Flag Coverage Δ
badger_v1 8.04% <0.00%> (ø)
badger_v2 1.92% <0.00%> (ø)
cassandra-3.x-v1 16.60% <0.00%> (ø)
cassandra-3.x-v2 1.84% <0.00%> (ø)
cassandra-4.x-v1 16.60% <0.00%> (ø)
cassandra-4.x-v2 1.84% <0.00%> (ø)
elasticsearch-7.x-v1 18.88% <0.00%> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.07% <0.00%> (ø)
elasticsearch-8.x-v2 19.07% <0.00%> (-0.02%) ⬇️
grpc_v1 9.46% <75.00%> (-0.02%) ⬇️
grpc_v2 7.49% <50.00%> (ø)
kafka 9.76% <100.00%> (ø)
opensearch-1.x-v1 18.93% <0.00%> (+0.01%) ⬆️
opensearch-2.x-v1 18.93% <0.00%> (ø)
opensearch-2.x-v2 18.93% <0.00%> (+0.01%) ⬆️
unittests 94.26% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title Simplify configs Simplify configs organization Jun 30, 2024
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Jun 30, 2024
@yurishkuro yurishkuro marked this pull request as ready for review June 30, 2024 21:30
@yurishkuro yurishkuro requested a review from a team as a code owner June 30, 2024 21:30
@yurishkuro yurishkuro merged commit 9ba3238 into jaegertracing:main Jun 30, 2024
44 of 45 checks passed
@yurishkuro yurishkuro deleted the configs branch June 30, 2024 22:13
@yurishkuro yurishkuro added v2 changelog:exprimental Change to an experimental part of the code and removed changelog:skip Trivial change that does not require an entry in CHANGELOG changelog:bugfix-or-minor-feature labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants