[bug] [hotrod] Delay env var mapping until logger is initialized #5760
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5760 +/- ##
==========================================
- Coverage 96.67% 96.65% -0.03%
==========================================
Files 341 341
Lines 16451 16451
==========================================
- Hits 15904 15900 -4
- Misses 360 362 +2
- Partials 187 189 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joeyyy09
approved these changes
Jul 17, 2024
FlamingSaint
pushed a commit
to FlamingSaint/jaeger
that referenced
this pull request
Jul 20, 2024
…gertracing#5760) ## Which problem is this PR solving? - Resolves jaegertracing#5759 ## Description of the changes - Invoke mapping function (which takes logger) after the logger is initialized - It is safe to do because none of the env vars control the logic for logger initialization ## How was this change tested? - `$ JAEGER_AGENT_PORT=xyz go run ./examples/hotrod all` - Before the change this command would cause a panic Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
$ JAEGER_AGENT_PORT=xyz go run ./examples/hotrod all