Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure hotrod image is published at the end of e2e test #5764

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Continue the script on successful test
  • Publish the image at the end

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner July 18, 2024 22:26
Signed-off-by: Yuri Shkuro <github@ysh.us>
@dosubot dosubot bot added the bug label Jul 18, 2024
@yurishkuro yurishkuro changed the title Ensure image is published at the end Ensure hotrod image is published at the end of e2e test Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (edfee78) to head (b667321).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5764      +/-   ##
==========================================
+ Coverage   96.65%   96.66%   +0.01%     
==========================================
  Files         341      341              
  Lines       16451    16451              
==========================================
+ Hits        15900    15902       +2     
+ Misses        362      361       -1     
+ Partials      189      188       -1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.90% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.82% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.82% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.83% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v1 19.02% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.90% <ø> (+0.01%) ⬆️
grpc_v1 9.52% <ø> (+0.01%) ⬆️
grpc_v2 7.46% <ø> (ø)
kafka 9.74% <ø> (ø)
memory_v2 1.88% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.88% <ø> (ø)
opensearch-2.x-v1 18.88% <ø> (ø)
opensearch-2.x-v2 1.90% <ø> (ø)
unittests 95.08% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 813ff32 into jaegertracing:main Jul 19, 2024
43 of 45 checks passed
@yurishkuro yurishkuro deleted the fix-5740 branch July 19, 2024 02:36
FlamingSaint pushed a commit to FlamingSaint/jaeger that referenced this pull request Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants