Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use image tag without version #5783

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jul 28, 2024

Which problem is this PR solving?

Description of the changes

  • Remove usage of no-version tags --tag docker.io/foo/bar completely
  • Fix unit tests, make them stricter

How was this change tested?

  • Unit tests

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner July 28, 2024 02:03
@dosubot dosubot bot added the docker Pull requests that update Docker code label Jul 28, 2024
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.66%. Comparing base (ed5cc29) to head (330b803).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5783   +/-   ##
=======================================
  Coverage   96.66%   96.66%           
=======================================
  Files         342      342           
  Lines       16519    16519           
=======================================
  Hits        15968    15968           
  Misses        362      362           
  Partials      189      189           
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.81% <ø> (ø)
cassandra-3.x-v1 16.61% <ø> (ø)
cassandra-3.x-v2 1.74% <ø> (ø)
cassandra-4.x-v1 16.61% <ø> (ø)
cassandra-4.x-v2 1.74% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.84% <ø> (ø)
elasticsearch-8.x-v1 19.02% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.80% <ø> (ø)
grpc_v1 9.51% <ø> (ø)
grpc_v2 7.14% <ø> (+0.01%) ⬆️
kafka 9.74% <ø> (ø)
memory_v2 1.80% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.88% <ø> (ø)
opensearch-2.x-v1 18.89% <ø> (ø)
opensearch-2.x-v2 1.81% <ø> (+0.01%) ⬆️
unittests 95.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit a8e98d9 into jaegertracing:main Jul 28, 2024
44 of 46 checks passed
@yurishkuro yurishkuro deleted the compute-tags-no-latest-v2 branch July 28, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: jaegertracing/all-in-one:latest does not match the latest Docker versioned tag nor the latest git tag
2 participants