[v2] Enable remote sampling extension and include in e2e tests #5802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
v2
changelog:exprimental
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5802 +/- ##
=======================================
Coverage 96.66% 96.66%
=======================================
Files 342 342
Lines 16520 16521 +1
=======================================
+ Hits 15969 15970 +1
Misses 362 362
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 7, 2024
…rtracing#5802) ## Which problem is this PR solving? - Resolves jaegertracing#5531 ## Description of the changes - Enable remote sampling extension in v2 all-in-one configuration - Fix Dockerfile to copy this into the image in the appropriate location - Change the default ports for the extension to match OTEL & agent 5778/5779 - Re-enable sampling e2e tests for v2 all-in-one ## How was this change tested? - `make all-in-one-integration-test` - CI Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 8, 2024
…rtracing#5802) ## Which problem is this PR solving? - Resolves jaegertracing#5531 ## Description of the changes - Enable remote sampling extension in v2 all-in-one configuration - Fix Dockerfile to copy this into the image in the appropriate location - Change the default ports for the extension to match OTEL & agent 5778/5779 - Re-enable sampling e2e tests for v2 all-in-one ## How was this change tested? - `make all-in-one-integration-test` - CI Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 13, 2024
…rtracing#5802) ## Which problem is this PR solving? - Resolves jaegertracing#5531 ## Description of the changes - Enable remote sampling extension in v2 all-in-one configuration - Fix Dockerfile to copy this into the image in the appropriate location - Change the default ports for the extension to match OTEL & agent 5778/5779 - Re-enable sampling e2e tests for v2 all-in-one ## How was this change tested? - `make all-in-one-integration-test` - CI Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 14, 2024
…rtracing#5802) ## Which problem is this PR solving? - Resolves jaegertracing#5531 ## Description of the changes - Enable remote sampling extension in v2 all-in-one configuration - Fix Dockerfile to copy this into the image in the appropriate location - Change the default ports for the extension to match OTEL & agent 5778/5779 - Re-enable sampling e2e tests for v2 all-in-one ## How was this change tested? - `make all-in-one-integration-test` - CI Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
4 tasks
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 28, 2024
…rtracing#5802) ## Which problem is this PR solving? - Resolves jaegertracing#5531 ## Description of the changes - Enable remote sampling extension in v2 all-in-one configuration - Fix Dockerfile to copy this into the image in the appropriate location - Change the default ports for the extension to match OTEL & agent 5778/5779 - Re-enable sampling e2e tests for v2 all-in-one ## How was this change tested? - `make all-in-one-integration-test` - CI Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
make all-in-one-integration-test