Add hardcoded DB password and username to Cassandra integration test #5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yurishkuro, |
Signed-off-by: Ali-Alnosairi <alialnosiari@gmail.com>
yurishkuro
reviewed
Aug 6, 2024
| @@ -48,14 +52,16 @@ run_integration_test() { | |||
| local major_version=${version%%.*} | |||
| local schema_version=$2 | |||
| local jaegerVersion=$3 | |||
| local username="username" | |||
| local password="password" | |||
There was a problem hiding this comment.
why does this function need to change? If you need to reuse these values, make them global vars. If you don't need to reuse them then just pass constant strings in the one place where they are needed?
There was a problem hiding this comment.
I added username and password as vars in cassandra-integration-test just to align with how keyspaces are managed, so even the keyspace can be passed as constant string to the apply-schema() but it is done as vars.
Another case if it is decided to pass username and password from the main() as user input or from the CI, this would be great start for that.
|
This script IS the CI. |
yurishkuro
reviewed
Aug 20, 2024
yurishkuro
added
the
changelog:ci
… through docker-compose Signed-off-by: Ali-Alnosairi <alialnosiari@gmail.com>
Ali-Alnosairi
force-pushed
the
good-first-issue
branch
from
e2c7710
to
40dd1ee
Compare
… to enable authentication Signed-off-by: Ali-Alnosairi <alialnosiari@gmail.com>
Ali-Alnosairi
force-pushed
the
good-first-issue
branch
from
eeda567
to
7c2dca9
Compare
Signed-off-by: Ali-Alnosairi <alialnosiari@gmail.com>
|
make sure to rebase on main, it will pull changes that give better logging in v2 tests |
Signed-off-by: Ali-Alnosairi <alialnosiari@gmail.com>
|
Would you please review the changes! I think it is finally ready. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5805 +/- ##
==========================================
+ Coverage 96.81% 96.82% +0.01%
==========================================
Files 342 342
Lines 16525 16520 -5
==========================================
- Hits 15998 15996 -2
+ Misses 340 338 -2
+ Partials 187 186 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Aug 23, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
|
@yurishkuro Thank you for your help and guidance. |
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 28, 2024
…aegertracing#5805) ## Which problem is this PR solving? - Resolves jaegertracing#5643 ## Description of the changes - add db password and username to cassandra-integration-test.sh - add db password and username to config-cassandra.yaml - both password and username are hardcoded in the code ## How was this change tested? - `bash scripts/cassandra-integration-test.sh 3 v003 v1` - `bash scripts/cassandra-integration-test.sh 3 v003 v2` - `bash scripts/cassandra-integration-test.sh 4 v004 v1 ` - `bash scripts/cassandra-integration-test.sh 4 v004 v2` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ali-Alnosairi <alialnosiari@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
mahadzaryab1
pushed a commit
to mahadzaryab1/jaeger
that referenced
this pull request
Aug 31, 2024
…aegertracing#5805) ## Which problem is this PR solving? - Resolves jaegertracing#5643 ## Description of the changes - add db password and username to cassandra-integration-test.sh - add db password and username to config-cassandra.yaml - both password and username are hardcoded in the code ## How was this change tested? - `bash scripts/cassandra-integration-test.sh 3 v003 v1` - `bash scripts/cassandra-integration-test.sh 3 v003 v2` - `bash scripts/cassandra-integration-test.sh 4 v004 v1 ` - `bash scripts/cassandra-integration-test.sh 4 v004 v2` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Ali-Alnosairi <alialnosiari@gmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
bash scripts/cassandra-integration-test.sh 3 v003 v1bash scripts/cassandra-integration-test.sh 3 v003 v2bash scripts/cassandra-integration-test.sh 4 v004 v1bash scripts/cassandra-integration-test.sh 4 v004 v2Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test