Update expected codecov flags count to 19 #5811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
added
the
changelog:ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5811 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 342 342
Lines 16521 16521
=======================================
Hits 15968 15968
Misses 363 363
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Wise-Wizard
approved these changes
Aug 7, 2024
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 7, 2024
## Which problem is this PR solving? We are now running 19 different uploads of codecov <img width="403" alt="image" src="https://github.com/user-attachments/assets/d31594c5-6b76-4e12-bb98-60902addd976"> However, the current configuration was only waiting for 11, which resulted in false positives like this: <img width="904" alt="image" src="https://github.com/user-attachments/assets/182f1578-53aa-476c-80e6-2d71428ce66c"> I.e. a comment about non-covered code which is actually covered, but its result uploads came after the 11 other results. ## Description of the changes - Bump expected count to 19, the current number of distinct flags/uploads. Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 8, 2024
## Which problem is this PR solving? We are now running 19 different uploads of codecov <img width="403" alt="image" src="https://github.com/user-attachments/assets/d31594c5-6b76-4e12-bb98-60902addd976"> However, the current configuration was only waiting for 11, which resulted in false positives like this: <img width="904" alt="image" src="https://github.com/user-attachments/assets/182f1578-53aa-476c-80e6-2d71428ce66c"> I.e. a comment about non-covered code which is actually covered, but its result uploads came after the 11 other results. ## Description of the changes - Bump expected count to 19, the current number of distinct flags/uploads. Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 13, 2024
## Which problem is this PR solving? We are now running 19 different uploads of codecov <img width="403" alt="image" src="https://github.com/user-attachments/assets/d31594c5-6b76-4e12-bb98-60902addd976"> However, the current configuration was only waiting for 11, which resulted in false positives like this: <img width="904" alt="image" src="https://github.com/user-attachments/assets/182f1578-53aa-476c-80e6-2d71428ce66c"> I.e. a comment about non-covered code which is actually covered, but its result uploads came after the 11 other results. ## Description of the changes - Bump expected count to 19, the current number of distinct flags/uploads. Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 14, 2024
## Which problem is this PR solving? We are now running 19 different uploads of codecov <img width="403" alt="image" src="https://github.com/user-attachments/assets/d31594c5-6b76-4e12-bb98-60902addd976"> However, the current configuration was only waiting for 11, which resulted in false positives like this: <img width="904" alt="image" src="https://github.com/user-attachments/assets/182f1578-53aa-476c-80e6-2d71428ce66c"> I.e. a comment about non-covered code which is actually covered, but its result uploads came after the 11 other results. ## Description of the changes - Bump expected count to 19, the current number of distinct flags/uploads. Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 28, 2024
## Which problem is this PR solving? We are now running 19 different uploads of codecov <img width="403" alt="image" src="https://github.com/user-attachments/assets/d31594c5-6b76-4e12-bb98-60902addd976"> However, the current configuration was only waiting for 11, which resulted in false positives like this: <img width="904" alt="image" src="https://github.com/user-attachments/assets/182f1578-53aa-476c-80e6-2d71428ce66c"> I.e. a comment about non-covered code which is actually covered, but its result uploads came after the 11 other results. ## Description of the changes - Bump expected count to 19, the current number of distinct flags/uploads. Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We are now running 19 different uploads of codecov
However, the current configuration was only waiting for 11, which resulted in false positives like this:
I.e. a comment about non-covered code which is actually covered, but its result uploads came after the 11 other results.
Description of the changes