Clean up obsolete 'version' tag from docker-compose files #5826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vvs-personalstash <viralkverma0987@gmail.com>
yurishkuro
added
the
changelog:ci
|
hint: to make checkbox as checked you just need to put x in it: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5826 +/- ##
==========================================
+ Coverage 96.79% 96.81% +0.01%
==========================================
Files 342 342
Lines 16525 16525
==========================================
+ Hits 15996 15998 +2
+ Misses 341 340 -1
+ Partials 188 187 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
changed the title
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 13, 2024
…ing#5826) ## Description of the changes - As the latest updates in docker compose has deprecated the 'version' tag.This Pr aims to cleanup the version tags in the various docker-compose files so as to cleanup the log currently displaying ```'version' is obselete ``` when we run a docker-compose file. ## Checklist - [ ✅ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ✅ ] I have signed all commits - [ ❌] I have added unit tests for the new functionality - [ ✅ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: vvs-personalstash <viralkverma0987@gmail.com> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 14, 2024
…ing#5826) ## Description of the changes - As the latest updates in docker compose has deprecated the 'version' tag.This Pr aims to cleanup the version tags in the various docker-compose files so as to cleanup the log currently displaying ```'version' is obselete ``` when we run a docker-compose file. ## Checklist - [ ✅ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ✅ ] I have signed all commits - [ ❌] I have added unit tests for the new functionality - [ ✅ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: vvs-personalstash <viralkverma0987@gmail.com> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95
pushed a commit
to JaredTan95/jaeger
that referenced
this pull request
Aug 28, 2024
…ing#5826) ## Description of the changes - As the latest updates in docker compose has deprecated the 'version' tag.This Pr aims to cleanup the version tags in the various docker-compose files so as to cleanup the log currently displaying ```'version' is obselete ``` when we run a docker-compose file. ## Checklist - [ ✅ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ✅ ] I have signed all commits - [ ❌] I have added unit tests for the new functionality - [ ✅ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: vvs-personalstash <viralkverma0987@gmail.com> Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
'version' is obseletewhen we run a docker-compose file.Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test