Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod for Docker Debug Image #5852

Merged
merged 5 commits into from
Aug 17, 2024
Merged

Conversation

hellspawn679
Copy link
Contributor

@hellspawn679 hellspawn679 commented Aug 15, 2024

Which problem is this PR solving?

Description of the changes

  • added go.mod for docker/debug

How was this change tested?

Checklist

Signed-off-by: mehul gautam <mehulsharma4786@gamil.com>
@hellspawn679 hellspawn679 requested a review from a team as a code owner August 15, 2024 08:47
@dosubot dosubot bot added docker Pull requests that update Docker code go labels Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.79%. Comparing base (0facc52) to head (c6397b8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #5852       +/-   ##
=========================================
+ Coverage      0   96.79%   +96.79%     
=========================================
  Files         0      342      +342     
  Lines         0    16522    +16522     
=========================================
+ Hits          0    15993    +15993     
- Misses        0      341      +341     
- Partials      0      188      +188     
Flag Coverage Δ
badger_v1 8.05% <ø> (?)
badger_v2 1.81% <ø> (?)
cassandra-3.x-v1 16.61% <ø> (?)
cassandra-3.x-v2 1.74% <ø> (?)
cassandra-4.x-v1 16.61% <ø> (?)
cassandra-4.x-v2 1.74% <ø> (?)
elasticsearch-6.x-v1 18.77% <ø> (?)
elasticsearch-7.x-v1 18.84% <ø> (?)
elasticsearch-8.x-v1 19.02% <ø> (?)
elasticsearch-8.x-v2 1.80% <ø> (?)
grpc_v1 9.51% <ø> (?)
grpc_v2 7.14% <ø> (?)
kafka-v1 9.74% <ø> (?)
kafka-v2 1.81% <ø> (?)
memory_v2 1.81% <ø> (?)
opensearch-1.x-v1 18.88% <ø> (?)
opensearch-2.x-v1 18.89% <ø> (?)
opensearch-2.x-v2 1.80% <ø> (?)
unittests 95.27% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docker/debug/go.mod Outdated Show resolved Hide resolved
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Aug 15, 2024
mehul gautam and others added 2 commits August 16, 2024 17:02
Signed-off-by: mehul gautam <mehulsharma4786@gamil.com>
COPY go.mod go.sum /go/src/debug-delve/
WORKDIR /go/src/debug-delve
# Download dependencies (including Delve)
RUN go mod download
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want this command to only run before L20, inside the if statement (otherwise it might fail on unsupported architectures)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, you can do cd /go/src/debug-delve && go mod download instead of using WORKDIR

@yurishkuro
Copy link
Member

yurishkuro commented Aug 16, 2024

please write proper/descriptive PR title

@hellspawn679 hellspawn679 changed the title added go.mod Added go.mod for Docker Debug Image Aug 17, 2024
hellspawn679 and others added 2 commits August 17, 2024 20:30
Signed-off-by: mehul gautam <mehulsharma4786@gamil.com>
@yurishkuro yurishkuro changed the title Added go.mod for Docker Debug Image Add go.mod for Docker Debug Image Aug 17, 2024
@yurishkuro yurishkuro merged commit 2931a01 into jaegertracing:main Aug 17, 2024
43 checks passed
yurishkuro added a commit that referenced this pull request Aug 17, 2024
Follow-up fix for #5852 and #5850

---------

Signed-off-by: Mend Renovate <bot@renovateapp.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 28, 2024
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
JaredTan95 pushed a commit to JaredTan95/jaeger that referenced this pull request Aug 28, 2024
Follow-up fix for jaegertracing#5852 and jaegertracing#5850

---------

Signed-off-by: Mend Renovate <bot@renovateapp.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Co-authored-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Jared Tan <jian.tan@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin the version of Delve in the debug images
2 participants