Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Bundling of UI assets #5917

Merged
merged 19 commits into from
Sep 2, 2024
Merged

Simplify Bundling of UI assets #5917

merged 19 commits into from
Sep 2, 2024
+121 −63

Commits on Sep 1, 2024

  1. Remove Dependency on ui Build Tag 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    dc470ff View commit details
    Browse the repository at this point in the history

  2. Fix Documentation For ui Package 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    4f0cad6 View commit details
    Browse the repository at this point in the history

  3. Fix Contribution Guide 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    435fc38 View commit details
    Browse the repository at this point in the history

  4. Fix Placeholder index.html To Remove Reference To Tags 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    54d12b7 View commit details
    Browse the repository at this point in the history

  5. Remove ui Tags From Makefile Targets 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    b1de7bd View commit details
    Browse the repository at this point in the history

  6. Add godoc Comment For New Helper 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    c5c9cb8 View commit details
    Browse the repository at this point in the history

  7. Add Warning Log 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    3f900ae View commit details
    Browse the repository at this point in the history

  8. Fix godoc Comment 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    8dd1053 View commit details
    Browse the repository at this point in the history

  9. Provide Logger From Static Handler 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    1a7eb63 View commit details
    Browse the repository at this point in the history

  10. Fix Linting Error 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    7397acc View commit details
    Browse the repository at this point in the history

  11. Add Test For Non Existing Assets Case 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    db19d3a View commit details
    Browse the repository at this point in the history

  12. Swap Out Wrong Import 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    c69cbb6 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Address Feedback From PR Review 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    ed259ec View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into simplify-ui-binding

    @mahadzaryab1
    mahadzaryab1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b5e1bc7 View commit details
    Browse the repository at this point in the history

  3. Pass Logger To Tests 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    331536d View commit details
    Browse the repository at this point in the history

  4. Add Test For Actual Present Case 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7551104 View commit details
    Browse the repository at this point in the history

  5. Run Formatter 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a312899 View commit details
    Browse the repository at this point in the history

  6. Fix Comment 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f4c63f4 View commit details
    Browse the repository at this point in the history

  7. Add Empty Test 

    Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
    @mahadzaryab1
    mahadzaryab1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    2b62656 View commit details
    Browse the repository at this point in the history