Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using v1 and v1.x tags for Docker images #5956

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 8, 2024

Which problem is this PR solving?

  • We used to publish Docker tags like "1" and "1.60", which were aliases to the most recent fully-qualified version. This is a bad practice, nobody should be depending on those aliases since they can introduce unexpected changes to production
  • Part of [jaeger-v2] Release process #5889

Description of the changes

  • Only apply fully qualified vX.Y.Z tag
  • Do not generate any tags for runs not on main branch and not on numbered release
  • Rename poorly named internal action actions/block-pr-not-on-main to actions/block-pr-from-main-branch
  • Remove name from many workflow steps as it's redundant
  • Add "::group::" boundaries to log output to make it easier to navigate on github

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner September 8, 2024 20:22
@dosubot dosubot bot added the docker Pull requests that update Docker code label Sep 8, 2024
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Sep 8, 2024
@yurishkuro yurishkuro changed the title Stop using v1 and v1.x tags for Docker images Stop using v1 and v1.x and latest tags for Docker images Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.82%. Comparing base (9bdd368) to head (3580e25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5956   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files         345      345           
  Lines       16518    16518           
=======================================
  Hits        15993    15993           
  Misses        339      339           
  Partials      186      186           
Flag Coverage Δ
badger_v1 8.03% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.75% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.79% <ø> (ø)
elasticsearch-7.x-v1 18.85% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.04% <ø> (ø)
elasticsearch-8.x-v2 1.81% <ø> (ø)
grpc_v1 9.49% <ø> (+0.01%) ⬆️
grpc_v2 7.16% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.82% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.90% <ø> (+0.01%) ⬆️
opensearch-2.x-v1 18.90% <ø> (ø)
opensearch-2.x-v2 1.82% <ø> (+0.01%) ⬆️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title Stop using v1 and v1.x and latest tags for Docker images Stop using v1 and v1.x tags for Docker images Sep 8, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit e667eea into jaegertracing:main Sep 9, 2024
49 checks passed
@yurishkuro yurishkuro deleted the release-v2-cleanup branch September 9, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant