Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for retrieving unadjusted/raw spans #615

Merged
merged 2 commits into from
Dec 23, 2017
Merged

Add support for retrieving unadjusted/raw spans #615

merged 2 commits into from
Dec 23, 2017

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 23, 2017 •
edited
Loading

Fixes #617

@ghost ghost assigned yurishkuro Dec 23, 2017
@ghost ghost added the review label Dec 23, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6b5b0b0 on support-retrieving-unadjusted-spans into 8d6d07a on master.

Add support for retrieving unadjusted/raw spans
b65226d 
Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro yurishkuro force-pushed the support-retrieving-unadjusted-spans branch from 6b5b0b0 to b65226d Compare December 23, 2017 06:35
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 100.0% when pulling b65226d on support-retrieving-unadjusted-spans into ecbe0dd on master.

black-adder
black-adder approved these changes Dec 23, 2017
View reviewed changes
Copy link
Contributor

@black-adder black-adder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be super useful for debugging purposes. Do you mind updating the PR description as to why this is useful for future me when I forget?

Fix nits from previous review
960d5de 
Signed-off-by: Yuri Shkuro <ys@uber.com>
@yurishkuro
Copy link
Member Author

Do you mind updating the PR description as to why this is useful for future me when I forget?

Added an actual issue (I thought we had it already). Once you try it you'll never forget it!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 100.0% when pulling 960d5de on support-retrieving-unadjusted-spans into ecbe0dd on master.

@yurishkuro yurishkuro merged commit a97dfbe into master Dec 23, 2017
@ghost ghost removed the review label Dec 23, 2017
@yurishkuro yurishkuro deleted the support-retrieving-unadjusted-spans branch December 23, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-adder black-adder black-adder approved these changes

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@vprithvi vprithvi Awaiting requested review from vprithvi

Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yurishkuro @coveralls @black-adder