Make sure different tracers in HotROD process use different RNG seeds #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
requested review from
black-adder,
pavolloffay and
vprithvi
as code owners
ghost
assigned …nerator seeds Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
force-pushed
the
dedupe-random
branch
from
165d632
to
7cff9c6
Compare
black-adder
approved these changes
Feb 28, 2018
|
Yes, but maybe there was another cause. I certainly was able to reproduce same-IDs from different tracers scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a case where trace had spans with the same IDs. The RNG is seeded with time.Now().UnixNano(), which potentially can give identical values over several calls (since the clock precision is not actually nanos).
This is a quick (hacky) workaround. A proper fix needs to be in the Jaeger client.
Signed-off-by: Yuri Shkuro ys@uber.com