Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function #822

Merged
merged 1 commit into from
May 15, 2018
Merged

Remove unused function #822

merged 1 commit into from
May 15, 2018

Conversation

vprithvi
Copy link
Contributor

Which problem is this PR solving?

  • Reducing complexity by removing an unused function

Short description of the changes

  • Remove timeIntervalToPoints

Signed-off-by: Prithvi Raj p.r@uber.com

- It seems to be only used in a test for the same.

Signed-off-by: Prithvi Raj <p.r@uber.com>
@ghost ghost assigned vprithvi May 15, 2018
@ghost ghost added the review label May 15, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a50bad8 on cleanup-dependencyReader into a4706c0 on master.

@yurishkuro yurishkuro merged commit b5ade19 into master May 15, 2018
@ghost ghost removed the review label May 15, 2018
mabn pushed a commit to mabn/jaeger that referenced this pull request May 28, 2018
* master: (38 commits)
  Preparing release 1.5.0 (jaegertracing#847)
  Add bounds to memory storage (jaegertracing#845)
  Add metric for debug traces (jaegertracing#796)
  Change metrics naming scheme (jaegertracing#776)
  Bump gocql version (jaegertracing#829)
  Remove ParentSpanID from domain model (jaegertracing#831)
  Make gas run quiet (jaegertracing#838)
  Revert "Make gas run quite"
  Revert "Install gas from install-ci"
  Install gas from install-ci
  Make gas run quite
  Add 'gas' for security problems scanning (jaegertracing#830)
  Add ability to adjust static sampling probabilities per operation (jaegertracing#827)
  Support log-level flag on agent (jaegertracing#828)
  Remove unused function (jaegertracing#822)
  Add healthcheck to standalone (jaegertracing#784)
  Do not use KeyValue fields directly and use KeyValues as decorator only (jaegertracing#810)
  Add ContaAzul to the adopters list (jaegertracing#806)
  Add ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE (jaegertracing#805)
  Upgrade to  go 1.10 (jaegertracing#792)
  ...

# Conflicts:
#	cmd/agent/app/builder.go
#	cmd/collector/main.go
#	cmd/query/main.go
#	cmd/standalone/main.go
@vprithvi vprithvi deleted the cleanup-dependencyReader branch August 22, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants