Update collector metric counters to have a name #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Won Jun Jang <wjang@uber.com>
black-adder
requested review from
jpkrohling,
pavolloffay,
vprithvi and
yurishkuro
as code owners
ghost
assigned 
yurishkuro
approved these changes
Jun 25, 2018
cmd/collector/app/metrics_test.go
Outdated
| @@ -57,7 +57,7 @@ func TestProcessorMetrics(t *testing.T) { | |||
|
|
|||
| func TestNewCountsBySvc(t *testing.T) { | |||
| baseMetrics := jaegerM.NewLocalFactory(time.Hour) | |||
| metrics := newCountsBySvc(baseMetrics, 3) | |||
| metrics := newCountsBySvc(baseMetrics, "", 3) | |||
There was a problem hiding this comment.
can we change this test to reflect the usage (i.e. not a blank arg)?
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 126 126
Lines 6051 6052 +1
=====================================
+ Hits 6051 6052 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Won Jun Jang wjang@uber.com
Which problem is this PR solving?
Short description of the changes