Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the gRPC port to the docker-all-in-one Dockerfile (#773) #967

Merged
merged 1 commit into from
Jul 30, 2018

Conversation

heyleke
Copy link

@heyleke heyleke commented Jul 30, 2018

Which problem is this PR solving?

  • gRPC Prototype has all-in-one-support, but the dockerfile doesn't expose the port yet

Short description of the changes

  • add the port to the all-in-one Dockerfile

@yurishkuro yurishkuro merged commit c10e1d6 into jaegertracing:grpc Jul 30, 2018
yurishkuro pushed a commit that referenced this pull request Jul 30, 2018
Signed-off-by: Jan Heylen <jan.heylen@nokia.com>
isaachier pushed a commit to isaachier/jaeger that referenced this pull request Sep 2, 2018
isaachier pushed a commit to isaachier/jaeger that referenced this pull request Sep 3, 2018
isaachier pushed a commit to isaachier/jaeger that referenced this pull request Sep 3, 2018
pavolloffay pushed a commit to pavolloffay/jaeger that referenced this pull request Nov 7, 2018
Signed-off-by: Yuri Shkuro <ys@uber.com>

Fix lint

Signed-off-by: Yuri Shkuro <ys@uber.com>

Add gRPC endpoint to collector

Signed-off-by: Yuri Shkuro <ys@uber.com>

Add proper grpc server

Signed-off-by: Yuri Shkuro <ys@uber.com>

Add grpc to all-in-one

Signed-off-by: Yuri Shkuro <ys@uber.com>

adds the gRPC port to the docker-all-in-one Dockerfile (jaegertracing#773) (jaegertracing#967)

Signed-off-by: Jan Heylen <jan.heylen@nokia.com>

Simple fixes (jaegertracing#999)

* Fix test error

Signed-off-by: Isaac Hier <ihier@uber.com>

* go fmt

Signed-off-by: Isaac Hier <ihier@uber.com>

Implement PostSpans for collector gRPC handler

Signed-off-by: Isaac Hier <isaachier@gmail.com>

Fix formatting

Signed-off-by: Isaac Hier <isaachier@gmail.com>

Remove timeout

Signed-off-by: Isaac Hier <ihier@uber.com>

Use expectedError variable

Signed-off-by: Isaac Hier <ihier@uber.com>
pavolloffay pushed a commit to pavolloffay/jaeger that referenced this pull request Nov 8, 2018
Signed-off-by: Yuri Shkuro <ys@uber.com>

Fix lint

Signed-off-by: Yuri Shkuro <ys@uber.com>

Add gRPC endpoint to collector

Signed-off-by: Yuri Shkuro <ys@uber.com>

Add proper grpc server

Signed-off-by: Yuri Shkuro <ys@uber.com>

Add grpc to all-in-one

Signed-off-by: Yuri Shkuro <ys@uber.com>

adds the gRPC port to the docker-all-in-one Dockerfile (jaegertracing#773) (jaegertracing#967)

Signed-off-by: Jan Heylen <jan.heylen@nokia.com>

Simple fixes (jaegertracing#999)

* Fix test error

Signed-off-by: Isaac Hier <ihier@uber.com>

* go fmt

Signed-off-by: Isaac Hier <ihier@uber.com>

Implement PostSpans for collector gRPC handler

Signed-off-by: Isaac Hier <isaachier@gmail.com>

Fix formatting

Signed-off-by: Isaac Hier <isaachier@gmail.com>

Remove timeout

Signed-off-by: Isaac Hier <ihier@uber.com>

Use expectedError variable

Signed-off-by: Isaac Hier <ihier@uber.com>

Agent - collector grpc

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

Working collector agent grpc

Signed-off-by: Pavol Loffay <ploffay@redhat.com>

Remove what is not needed

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants