Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the deployment setup of EmptyBeansXmlDiscoveryTest #471

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Jun 2, 2023

Fixes #470

Changes how the test deployment is created - doesn't change the functionality or contents of the test.

Draft PR until the challenge is accepted.

@manovotn manovotn marked this pull request as ready for review June 6, 2023 14:15
Copy link
Contributor

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The fix is pretty minor and the correct way to fix this. If some runtime challenges this, we can exclude this test and do a subsequent release.

@Ladicek Ladicek merged commit 80306ee into jakartaee:master Jun 6, 2023
@manovotn manovotn deleted the fixEmptyBeansXmlTestDeployment branch June 7, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EmptyBeansXmlDiscoveryTest has incorrect deployment configuration
3 participants