Fix compute_struct_fingerprints.py: cannot insert material_id, already exists
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y exists (closes #30)
pep8-naming pandas-vet flakes8-pyi flake8-return
E AssertionError: assert ['MEGNet', 'C... 'Voronoi RF'] == ['MEGNet', 'C...RF', 'metric'] E Right contains one more item: 'metric' E Full diff: E - ['MEGNet', 'CGCNN', 'Voronoi RF', 'metric'] E ? ---------- E + ['MEGNet', 'CGCNN', 'Voronoi RF']
janosh
added a commit
that referenced
this pull request
Jun 20, 2023
…ready exists (#31) * fix compute_struct_fingerprints.py: cannot insert material_id, already exists (closes #30) * add ruff rule sets pep8-naming pandas-vet flakes8-pyi flake8-return * add rows=2 x cols=4 version of each-scatter-models * add rows=2 x cols=4 version of hist-clf-(pred|true)-hull-dist-models * fix CI assert list(df_metrics) == [*models, "metric"] E AssertionError: assert ['MEGNet', 'C... 'Voronoi RF'] == ['MEGNet', 'C...RF', 'metric'] E Right contains one more item: 'metric' E Full diff: E - ['MEGNet', 'CGCNN', 'Voronoi RF', 'metric'] E ? ---------- E + ['MEGNet', 'CGCNN', 'Voronoi RF']
janosh
added a commit
that referenced
this pull request
Jun 20, 2023
…ready exists (#31) * fix compute_struct_fingerprints.py: cannot insert material_id, already exists (closes #30) * add ruff rule sets pep8-naming pandas-vet flakes8-pyi flake8-return * add rows=2 x cols=4 version of each-scatter-models * add rows=2 x cols=4 version of hist-clf-(pred|true)-hull-dist-models * fix CI assert list(df_metrics) == [*models, "metric"] E AssertionError: assert ['MEGNet', 'C... 'Voronoi RF'] == ['MEGNet', 'C...RF', 'metric'] E Right contains one more item: 'metric' E Full diff: E - ['MEGNet', 'CGCNN', 'Voronoi RF', 'metric'] E ? ---------- E + ['MEGNet', 'CGCNN', 'Voronoi RF']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c5eda47 fix compute_struct_fingerprints.py: cannot insert material_id, already exists (closes #30)
a7a1bb1 add ruff rule sets
10d06f7 add rows=2 x cols=4 version of each-scatter-models
a811f95 add rows=2 x cols=4 version of hist-clf-(pred|true)-hull-dist-models
fe1ae67 fix CI assert list(df_metrics) == [*models, "metric"]