Add PDF versions of all SI figures #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es.py and scripts/make_metrics_tables.py
…t-10k.svelte move site/src/figs/metrics-table-megnet-uip-combos.svelte
export models = list(df_metrics.T.MAE.sort_values().index) from preds.py add lanthanides and actinides versions of scatter-largest-errors-models-mean-vs-true-hull-dist-*.svelte
now used in make_metrics_tables.py and analyze_wrenformer.py
…-mean-vs-true-hull-dist.svelte plus set uniform x/y-range for all existing versions
…pPdfMargins not installed\n' in 'pdfkit not installed fix file path in test-scripts.yml
janosh
added a commit
that referenced
this pull request
Jun 20, 2023
* fix /models page layout on wide screens
* split scripts/compile_metrics.py into scripts/calc_wandb_model_runtimes.py and scripts/make_metrics_tables.py
* add accuracy col, drop TNR, TPR from site/src/figs/metrics-table-first-10k.svelte
move site/src/figs/metrics-table-megnet-uip-combos.svelte
* remove unintended vestage of M3GNet + MEGNetin ICLR abstract
* make all model plots in rolling_mae_vs_hull_dist_wbm_batches.py
* add save_fig("*.pdf") for all /si figs
export models = list(df_metrics.T.MAE.sort_values().index) from preds.py
add lanthanides and actinides versions of scatter-largest-errors-models-mean-vs-true-hull-dist-*.svelte
* add df_to_pdf() in plots.py and test_df_to_pdf()
now used in make_metrics_tables.py and analyze_wrenformer.py
* add lanthanide and actinide versions of scatter-largest-errors-models-mean-vs-true-hull-dist.svelte
plus set uniform x/y-range for all existing versions
* fix tests/test_plots.py::test_df_to_pdf - AssertionError: assert 'cropPdfMargins not installed\n' in 'pdfkit not installed
fix file path in test-scripts.yml
* wrap df_to_pdf in try/except to fix scripts/make_metrics_tables.py in CI
* update all remaining tmp/figs/* save_fig() paths to PDF_FIGS/*
janosh
added a commit
that referenced
this pull request
Jun 20, 2023
* fix /models page layout on wide screens
* split scripts/compile_metrics.py into scripts/calc_wandb_model_runtimes.py and scripts/make_metrics_tables.py
* add accuracy col, drop TNR, TPR from site/src/figs/metrics-table-first-10k.svelte
move site/src/figs/metrics-table-megnet-uip-combos.svelte
* remove unintended vestage of M3GNet + MEGNetin ICLR abstract
* make all model plots in rolling_mae_vs_hull_dist_wbm_batches.py
* add save_fig("*.pdf") for all /si figs
export models = list(df_metrics.T.MAE.sort_values().index) from preds.py
add lanthanides and actinides versions of scatter-largest-errors-models-mean-vs-true-hull-dist-*.svelte
* add df_to_pdf() in plots.py and test_df_to_pdf()
now used in make_metrics_tables.py and analyze_wrenformer.py
* add lanthanide and actinide versions of scatter-largest-errors-models-mean-vs-true-hull-dist.svelte
plus set uniform x/y-range for all existing versions
* fix tests/test_plots.py::test_df_to_pdf - AssertionError: assert 'cropPdfMargins not installed\n' in 'pdfkit not installed
fix file path in test-scripts.yml
* wrap df_to_pdf in try/except to fix scripts/make_metrics_tables.py in CI
* update all remaining tmp/figs/* save_fig() paths to PDF_FIGS/*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f50ed17 fix /models page layout on wide screens
19c9221 split scripts/compile_metrics.py into scripts/calc_wandb_model_runtimes.py and scripts/make_metrics_tables.py
9029ec5 add accuracy col, drop TNR, TPR from site/src/figs/metrics-table-first-10k.svelte
82f076b remove unintended vestage of M3GNet + MEGNetin ICLR abstract
8b5e4ce make all model plots in rolling_mae_vs_hull_dist_wbm_batches.py
31f9330 add save_fig("*.pdf") for all /si figs
c8fc9d0 add df_to_pdf() in plots.py and test_df_to_pdf()
c1ba15f add lanthanide and actinide versions of scatter-largest-errors-models-mean-vs-true-hull-dist.svelte