Correct the Properties tab in showcase.py #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Properties tab of showcase: 1- FontScale slider setup value as positinal argument was not taken into account (got lost in the new functions for v1.0 I guess). I made it a keyword argument and the slider is correctly positionned now. 2- Same for the TransparencyScale slider that was positioned at 0 instaed of 100. 3- There is a mismatch between inputs widgets and their labels, respectively in the right and left panedFrames. For a reason I ignore, the FontScale slider was displayed at the top of the right paned frame, while the coresponding label was at the bottom of the left panedFrame. This may have something to do with issue jarvisteach#301 "Not happy with layout" but I just tried appJar, created a GitHub account at last, and my time on this is up !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Properties tab of showcase:
1- FontScale slider setup value as positinal argument was not taken into account (got lost in the new functions for v1.0 I guess). I made it a keyword argument and the slider is correctly positionned now.
2- Same for the TransparencyScale slider that was positioned at 0 instaed of 100.
3- There is a mismatch between inputs widgets and their labels, respectively in the right and left panedFrames. For a reason I ignore, the FontScale slider was displayed at the top of the right paned frame, while the coresponding label was at the bottom of the left panedFrame. This may have something to do with issue #301 "Not happy with layout" but I just tried appJar, created a GitHub account at last, and my time on this is up !