Create JAX Advanced Tutorials (section, move/create docs) #23165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
requested changes
Aug 21, 2024
There was a problem hiding this comment.
Several of these sections are duplicative of existing docs (e.g. docs/external-callbacks.md and docs/notebooks/external_callbacks.md.
More work is necessary to de-duplicate these, update indices, and re-direct old URLs to the new locations. See #21064 for an example of how we did this in the past
Also, rather than creating new files, we should move the old files out of docs/_tutorials to their new location, in order to preserve change history.
8bitmp3
force-pushed
the
jax-docs-advanced-tutorials
branch
10 times, most recently
from
76ac690
to
726c8a2
Compare
jakevdp
reviewed
Sep 5, 2024
8bitmp3
force-pushed
the
jax-docs-advanced-tutorials
branch
2 times, most recently
from
29456b2
to
0fabd73
Compare
8bitmp3
force-pushed
the
jax-docs-advanced-tutorials
branch
from
0fabd73
to
c708b7c
Compare
8bitmp3
force-pushed
the
jax-docs-advanced-tutorials
branch
3 times, most recently
from
01e315b
to
95f7335
Compare
jakevdp
reviewed
Sep 11, 2024
8bitmp3
force-pushed
the
jax-docs-advanced-tutorials
branch
from
95f7335
to
65ce1bf
Compare
|
@jakevdp PTAL |
8bitmp3
force-pushed
the
jax-docs-advanced-tutorials
branch
from
038d7ad
to
a533635
Compare
8bitmp3
force-pushed
the
jax-docs-advanced-tutorials
branch
from
c9c3094
to
9465d42
Compare
8bitmp3
force-pushed
the
jax-docs-advanced-tutorials
branch
from
dc26b37
to
0cf040c
Compare
jakevdp
approved these changes
Sep 21, 2024
|
As we discussed, the structure of the left-nav dropdown is still not exactly how we'd like it, but we can land and iterate. Thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jakevdp