Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match apollo-client createBatchingNetworkInterface #18

Merged
merged 7 commits into from
Jun 24, 2017
Merged

Match apollo-client createBatchingNetworkInterface #18

merged 7 commits into from
Jun 24, 2017

Conversation

srtucker22
Copy link
Contributor

Just a tiny edit -- apollo-client has changed their batch API to createBatchingNetworkInterface

excellent package!

match apollo-client createBatchingNetworkInterface API
@jaydenseric
Copy link
Owner

jaydenseric commented Jun 23, 2017

Thanks for the contribution 🙂

When I created this API there was an open pull request for apollo-clientthat had positive momentum, that would have renamed their API to createBatchNetworkInterface.

For a while after the issue and pull request was in limbo and I was not sure if I changed the API here (frustrating users), there would be a good chance I would have to frustrate them again and change it back.

In the end, I decided not to change the API as it would be a breaking change for subjective reasons, we have the ability to call it whatever we like.

I agree that it is desirable to match the Apollo naming to make setup easier, so maybe it makes sense now to make the change since the situation looks to have stabilized.

@jaydenseric
Copy link
Owner

Lets do it, and go the whole hog. Since it will be a semver breaking release, lets rename the class extensions to closer match Apollo too.

Perhaps:

  • HTTPUploadNetworkInterface -> UploadHTTPFetchNetworkInterface, which extends HTTPFetchNetworkInterface.
  • HTTPUploadBatchNetworkInterface -> UploadHTTPBatchedNetworkInterface, which extends HTTPBatchedNetworkInterface.

@jaydenseric
Copy link
Owner

Update changelog.md and we can merge this bad boy.

@jaydenseric jaydenseric merged commit 1d83a83 into jaydenseric:master Jun 24, 2017
@jaydenseric
Copy link
Owner

This is now live in apollo-upload-client@5.0.0-beta.1 – once verified there are no issues with this release we can move out of of beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants