Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Functions #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

UvuvDev
Copy link
Contributor

@UvuvDev UvuvDev commented Jan 29, 2024

Added functions for zooming in automatically (graph fits within the bounds of the brain screen no matter what), for inserting a premade graph, and for getting a reference to the container.

Added functions for zooming in automatically (graph fits within the bounds of the brain screen no matter what), for inserting a premade graph, and for getting a reference to the container.
Copy link
Owner

@jazonshou jazonshou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small documentation issue. Also, could you please send a video/photo of you testing it on an actual brain? I'm sure it works, I just want to see what it does because I can't test it right now

@@ -47,7 +48,7 @@ class AsyncGrapher : public TaskWrapper {
* @param name data type name
* @param val updated data value
*/
void update(const std::string &name, double val);
void update(const std::string &name, double val, double maxValArg = 1);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the comment block to include documentation for maxValArg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants