Avoid setting color-scheme on :root, we're only a guest on pages #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,7 +56,6 @@ | |||
| } | |||
|
|
|||
| #djDebug[data-theme="dark"] { | |||
| color-scheme: dark; | |||
There was a problem hiding this comment.
Couldn't this one have stayed?
There was a problem hiding this comment.
I thought about it and I'm not sure what it even does since we're basically specifying all colors and backgrounds. Yes, it could stay, but then we'd also have to set the opposite on #djDebug[data-theme="light"] (I think)
The bigger point here is that while I do have much experience with CSS generally I don't really know how the color-scheme property behaves, and it felt safer to just remove it at this time.
There was a problem hiding this comment.
Alright that's fair.
There was a problem hiding this comment.
Btw, sorry for pressing ahead, I wanted to release a better version quickly instead of waiting for more reports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1922.
Checklist:
docs/changes.rst.