Add a paragraph describing our stance on Python typing #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-schilling
approved these changes
Aug 6, 2024
|
Do you think we should add something to address this concern? I totally agree with you but I have a hard time finding ways to describe this without referring to particular cases. |
|
I don't know. It feels like it's a thing we need to commit to or not. Otherwise we end up with code like this, which I'd argue is adding code to please a configuration. I think merging this PR is a step forward regardless. |
|
OK let's do it step by step. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should an official paragraph to the contributing docs regarding our stance on typing. I tried describing what we're doing currently since I think it makes sense, but I'm definitely open to changing this. I don't think we should open a big round of discussions on this though.