Allow raw identifiers. #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build failure for the coverage test is related to this pull request, and is unrelated to the changes in this PR. |
|
@Hoverbear Just a friendly ping. Do you have any feedback on this? |
|
@Anders429 I'm sorry, I didn't even see this! 😓 |
Hoverbear
approved these changes
Mar 19, 2021
|
Thank you, this is a great change. Sorry about the delays. |
|
No worries, I understand :) Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution to issue #63.
proc_macro2::Ident::new()doesn't allow raw identifiers, andproc_macro2::Ident::new_raw()provided by the same crate is unstable. Therefore, the solution here is to check if the identifier begins with "r#', and if so, keep the "r#" as long as there are no added prefixes and suffixes.In the other cases, we can use
syn::ext::IdentExt::unraw()to remove the rawness of the identifier.