This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
Add filter to skip registration of open generics with mismatched arity #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a recent change to the dotnet runtime, which now throws an exception upon the attempted registration of open generic types with a mismatched arity between service and implementation: dotnet/runtime#51167
Since dotnet will now explicitly disallow the registration of these types, MediatR should not attempt to register them.
I created this repo, https://github.com/markmillercc/MediatRClub, to provide more detail and to demonstrate how I've used these types of services successfully, and how to reproduce the error that occurs when upgrading the Microsoft packages.
Note: this problem can also be resolved via this open PR, which would allow for the exclusion of specified types: #107
Related: jbogard/MediatR#674