Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Nullable Reference Types #518

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Enable Nullable Reference Types #518

merged 1 commit into from
Jun 25, 2020

Conversation

rus-art
Copy link
Contributor

@rus-art rus-art commented May 17, 2020

Hi! This PR resolves #503

Added target framework netstandard2.1

I've assumed that:

  • request cannot be null in any way
  • response can be null
  • RequestExceptionHandlerState cannot be handled with response of null if generic parameter TResponse is declared as non-nullable

The source of file NullableAttributes.cs is this article

@lilasquared
Copy link
Contributor

Can you checkout Mediator.cs? Something might be wrong with your line endings, it is showing a full file diff.

@rus-art
Copy link
Contributor Author

rus-art commented May 17, 2020

@lilasquared Thanks, it's ok now

@rus-art rus-art mentioned this pull request May 17, 2020
Closed
@jbogard jbogard merged commit 2201472 into jbogard:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbogard jbogard jbogard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Nullable Reference Types
3 participants
@rus-art @lilasquared @jbogard