Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for eap-datagrid-subsystem #203

Open
wants to merge 1 commit into
base: jdg-7.2.x
Choose a base branch
from

Conversation

gbabcan
Copy link
Contributor

@gbabcan gbabcan commented Jun 4, 2018

No description provided.

@gbabcan gbabcan force-pushed the eap-subsystem branch 4 times, most recently from 3c4b18e to dd8bcc4 Compare June 7, 2018 08:53

Run tests
========================
1. Prepare the server instances and keep EAP server running
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you prepare server instances?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galderz I have updated the README. Hope now it is clear. Just need to follow steps from upper part of readme :)

@gbabcan gbabcan force-pushed the eap-subsystem branch 2 times, most recently from c1aa249 to d813242 Compare June 11, 2018 07:08
@galderz
Copy link
Collaborator

galderz commented Jun 13, 2018

I'm looking at the instructions for EAP set up, shouldn't the modules be copied into EAP/modules/system/layers/base folder?

@galderz
Copy link
Collaborator

galderz commented Jun 13, 2018

@galderz
Copy link
Collaborator

galderz commented Jun 14, 2018

I still see test errors after doing clean and package: https://gist.github.com/galderz/e8dbb29acc30bd8da1b39c00f6594e43

@galderz
Copy link
Collaborator

galderz commented Jun 14, 2018

The could be due to IP issues? The server is started in 127.0.0.1 but Selenium tries to connect to 192.168.1.125?

@gbabcan
Copy link
Contributor Author

gbabcan commented Jun 15, 2018

I have tried to run test on RHEL at OpenStack and I had no issues. Tests passed. So maybe it is because of some configuration of your Mac.

@galderz
Copy link
Collaborator

galderz commented Jun 15, 2018

Maybe... but there's no guarantee that the users of these quickstarts will be running on RHEL! So, can you make sure it can run on any platform?

@gbabcan
Copy link
Contributor Author

gbabcan commented Jun 18, 2018

Could You try this?
SeleniumHQ/selenium#2824 (comment)

@mgencur
Copy link
Contributor

mgencur commented Jul 10, 2018

@galderz , did you try what @gbabcan suggested? I'm curious how to move forward with this PR.

@galderz
Copy link
Collaborator

galderz commented Aug 6, 2018

@gbabcan @mgencur Didn't work. Still same issue after that. The error reported in that issue is different to mine anyway. @gbabcan Any idea how to get more logs out of this test to see what's up?

@alanfx
Copy link
Contributor

alanfx commented Aug 14, 2018

Hey @galderz, @gbabcan is no longer on the team, so I'll see if I can find someone to look at this.

@galderz
Copy link
Collaborator

galderz commented Aug 24, 2018

Shame that @gbabcan can't help complete this, even if he's in a different team.

@ghost
Copy link

ghost commented Oct 26, 2018

Can one of the admins verify this patch?

1 similar comment
@ghost
Copy link

ghost commented Oct 29, 2018

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants