Skip to content

Commit

Permalink
Merge pull request redpanda-data#4858 from dotnwat/no-timer-rval
Browse files Browse the repository at this point in the history
chore: fix warning backgrounding futures
  • Loading branch information
dotnwat committed May 22, 2022
2 parents 426aaec + 57c20cf commit 9198ee5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/v/cloud_storage/cache_service.cc
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ ss::future<> cache::start() {
if (ss::this_shard_id() == 0) {
co_await clean_up_at_start();

_timer.set_callback([this] { return clean_up_cache(); });
_timer.set_callback([this] { ssx::background = clean_up_cache(); });
_timer.arm_periodic(_check_period);
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/v/kafka/client/consumer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ consumer::consumer(
, _coordinator(std::move(coordinator))
, _inactive_timer([me{shared_from_this()}]() {
vlog(kclog.info, "Consumer: {}: inactive", *me);
return me->leave().discard_result().finally([me]() {});
ssx::background = me->leave().discard_result().finally([me]() {});
})
, _group_id(std::move(group_id))
, _name(std::move(name))
Expand Down

0 comments on commit 9198ee5

Please sign in to comment.