Skip to content

Commit

Permalink
south also needed
Browse files Browse the repository at this point in the history
  • Loading branch information
@jedie
jedie committed Jun 11, 2012
1 parent a4446bd commit 3e62a4a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def get_authors():
install_requires=[
"Django>=1.4",
"django-reversion>=1.6",
"south",
],
zip_safe=False,
classifiers=[
Expand Down

4 comments on commit 3e62a4a

@mlavin
Copy link

@mlavin mlavin commented on 3e62a4a Jun 12, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This app doesn't define any models so why is south required?

@jedie
Copy link
Owner Author

@jedie jedie commented on 3e62a4a Jun 12, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I added because running unittests on Travis failed, because django-reversion needs south...

On the other site in ".travis.yml" is "pip install South"...

Thanks for the hint...

@mlavin
Copy link

@mlavin mlavin commented on 3e62a4a Jun 12, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's only required for testing then it would probably be better to put in the tests_require or in the travis.yml. I'm working on integrating this into a project which for better or worse does not use South and it seemed like an unnecessary dependency. Not really a big deal though.

@jedie
Copy link
Owner Author

@jedie jedie commented on 3e62a4a Jun 12, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added "django-tools" and "south" to tests_require with: 3744f11

The "south" stuff have i IMHO added because of this, too: d9c01e2#L0R28
I must call "migrations" manually, because settings.SOUTH_TESTS_MIGRATE doesn't work.

Please sign in to comment.