Update inline assembly to support new syntax #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlb6740
force-pushed
the
update-inline-assembly-to-support-new-syntax
branch
from
9185f57
to
7030f5a
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jedisct1 It seems for recent versions of rust the inline assembly syntax currently originally used here is no longer valid (rust-lang/rust#69171). There is a workaround used here that calls for using llvm_asm! instead, but that solution is just renaming the now deprecated syntax and is considered unstable. Also ... oddly a strange compilation error occurred complaining of the llvm_asm syntax when compiling this on Aarch64 for as a sightglass dependency. Perhaps that was my error, but this patch updates to the new syntax and as implied, adds support for ARM.