Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading if statement #707

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Conversation

kovaacs
Copy link
Contributor

@kovaacs kovaacs commented Feb 7, 2023

('Season') is just a string in parentheses, not a tuple.

E.g., 'Sea' in ('Season') would be True

('Season') is just a string in parentheses, not a tuple
@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@mcarlton00 mcarlton00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

@mcarlton00 mcarlton00 added the cleanup Non-functional code cleanup/readability/formatting label Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #707 (3797ee2) into master (0a7faff) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   21.08%   21.08%           
=======================================
  Files          63       63           
  Lines        8527     8527           
  Branches     1452     1452           
=======================================
  Hits         1798     1798           
  Misses       6713     6713           
  Partials       16       16           
Impacted Files Coverage Δ
jellyfin_kodi/entrypoint/context.py 20.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mcarlton00 mcarlton00 merged commit 59559ee into jellyfin:master Feb 17, 2023
@kovaacs kovaacs deleted the fix-if-statement branch February 17, 2023 13:50
@oddstr13 oddstr13 changed the title fix misleading if statement Fix misleading if statement Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Non-functional code cleanup/readability/formatting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants