-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Device don't change device name in the devices page #4882
Comments
Does this happen to all devices or only the ones from the Home Assistant integration? Last time I checked the integration did not implement our API correctly which could introduce issues like this one. |
I tested on a chrome browser instance and on a roku |
Yes it's happening on all devices |
Same on Safari |
I wonder if this may be intentional - the display name is set correctly and reported in, for example, the Activity section with the correct device display name on playback. This is being saved as a separate entity to the device "name", which appears to not be user-settable (or certainly isn't affected by the process of editing the device as above). |
I can confirm that it happens on Firefox too. Looking here, this part of the code only uses the Name. jellyfin-web/src/controllers/dashboard/devices/devices.js Lines 122 to 128 in 4ecbe4d
I think the main problem is that the /Devices api endpoint only provides the Name and not the CustomName. I can see 2 ways of solving this issue:
|
I think adding the custom name to the |
If I have a vote, I would prefer to display just the |
Describe The Bug
When a device is renamed, the name isn't changed on the devices page.
On the Dashboard page, the device name is the new name.
Steps To Reproduce
Expected Behavior
The device name should have been changed
Logs
No log activity of this issue
Screenshots
![Screenshot 2023-10-15 at 11 07 14](https://private-user-images.githubusercontent.com/147994162/275335583-8d3bde59-3065-492b-a30b-21551cbd1ab0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxMDcyOTEsIm5iZiI6MTcyMDEwNjk5MSwicGF0aCI6Ii8xNDc5OTQxNjIvMjc1MzM1NTgzLThkM2JkZTU5LTMwNjUtNDkyYi1hMzBiLTIxNTUxY2JkMWFiMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwNFQxNTI5NTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02ZjAxZmUzYjhkY2IzYmM3ZjA4ODUzYWJjM2JmYTZmZWRhYjk2YTI2MTEwODlkNjVlNWFiMDVmOWE3ZTE0YmI5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.-X57whJtd7sGAGBuZGZr4cSN_WWO_kUb3zSzp4k31vQ)
![Screenshot 2023-10-15 at 11 18 46](https://private-user-images.githubusercontent.com/147994162/275335594-3be58bf8-29c5-440c-ae29-c0128b37181d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxMDcyOTEsIm5iZiI6MTcyMDEwNjk5MSwicGF0aCI6Ii8xNDc5OTQxNjIvMjc1MzM1NTk0LTNiZTU4YmY4LTI5YzUtNDQwYy1hZTI5LWMwMTI4YjM3MTgxZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzA0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcwNFQxNTI5NTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kODI2YWQyNjJiZTc4NWM2OTQyYzdjMThkZTc2ZjI3ODViNTJhYjUxZWE5OWNlYmFiZjUyZWFkYjhmMDkzMmI4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.oRN97xD7YG78zA6PB-7erc_chE3lhMttzGDBT3ovuVM)
System (please complete the following information):
The text was updated successfully, but these errors were encountered: