Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rename Device don't change device name in the devices page #4887

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Fix Rename Device don't change device name in the devices page #4887

merged 2 commits into from
Jan 4, 2024

Conversation

scampower3
Copy link
Member

@scampower3 scampower3 commented Oct 17, 2023 •
edited
Loading

Changes
Fixes Rename Device don't change device name in the devices page
Related to jellyfin/jellyfin#10422
Issues

Fixes #4882

@scampower3 scampower3 requested a review from a team as a code owner October 17, 2023 09:32
@scampower3 scampower3 mentioned this pull request Oct 17, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scampower3 scampower3 marked this pull request as draft October 17, 2023 10:30
@scampower3 scampower3 marked this pull request as ready for review October 17, 2023 16:42
@nielsvanvelzen nielsvanvelzen added the backend Requires work on the server to finish label Oct 18, 2023
@scampower3
Copy link
Member Author

Hey all, jellyfin/jellyfin#10422 has been merged into the main Jellyfin repo.

@thornbill thornbill added enhancement Improve existing functionality or small fixes and removed backend Requires work on the server to finish labels Jan 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 4, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit f6f4d22
Status ✅ Deployed!
Preview URL https://f24a47bf.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill merged commit b3cf6e4 into jellyfin:master Jan 4, 2024
21 of 22 checks passed
@Cyberbeni Cyberbeni mentioned this pull request Jan 13, 2024
Closed
@scampower3 scampower3 deleted the rename-fix-devices branch January 16, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename Device don't change device name in the devices page
4 participants
@scampower3 @jellyfin-bot @nielsvanvelzen @thornbill