Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide lyrics button when there are no lyrics #5439

Merged
merged 1 commit into from
May 1, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Hides the lyric button when there are no lyrics
  • Removes show/hide button functions

Issues
N/A

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Apr 30, 2024
@thornbill thornbill added this to the v10.9.0 milestone Apr 30, 2024
@thornbill thornbill added this to In progress in Release 10.9.z via automation Apr 30, 2024
@thornbill thornbill requested a review from a team as a code owner April 30, 2024 21:36
Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit c95592d
Status ✅ Deployed!
Preview URL https://602c271f.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill merged commit a3b5be0 into jellyfin:master May 1, 2024
10 checks passed
Release 10.9.z automation moved this from In progress to Done May 1, 2024
@thornbill thornbill deleted the no-lyrics-when-no-lyrics branch May 1, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants