Remove the result tag from the service check #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
jenkins.job.status
service check is currently reported with theresult
tag. This is useless as it creates two "groups" in monitor.The first group is
jenkins.job.status
withresult:SUCCESS
. This one always report "OK" and will never trigger a monitor.The second is
jenkins.job.status
withresult:FAILURE
. This one always report "CRITICAL" (sparsely).The
result
tag is what should make the value of the service check.