Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when traces collection is disabled #115

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

drodriguezhdez
Copy link
Collaborator

@drodriguezhdez drodriguezhdez commented Aug 28, 2020

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR prevents the invocation to the DatadogTraceBuildLogic and DatadogTracePipelineLogic instances when the APM trace collection is disabled.

This bug does not affect to any user in the v2.1.0 version cause the form data configuration save action does not create the default configuration for the traces. Related to #114

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez added changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue severity/major Major severity issue labels Aug 28, 2020
@drodriguezhdez drodriguezhdez self-assigned this Aug 28, 2020
@drodriguezhdez drodriguezhdez force-pushed the drodriguezhdez/fix_npe_traces_disabled branch from 8d6bcaa to 47f9263 Compare August 28, 2020 08:12
@drodriguezhdez drodriguezhdez merged commit f40b167 into master Aug 28, 2020
@drodriguezhdez drodriguezhdez deleted the drodriguezhdez/fix_npe_traces_disabled branch August 28, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue severity/major Major severity issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants