Add ci.queue_time for pipeline/stage/job traces

[drodriguezhdez]

Requirements for Contributing to this repository

• Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• The pull request must only fix one issue at the time.
• The pull request must update the test suite to demonstrate the changed functionality.
• After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Add ci.queue_time for pipeline/stage/job traces in Jenkins Build/Pipelines.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

• Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
• PR title must be written as a CHANGELOG entry (see why)
• Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
• PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
• PR should not have do-not-merge/ label attached.
• If Applicable, issue must have kind/ and severity/ labels attached at least.

[FlorianVeaux]

I don't follow that bit. We're propagating the time in queue of the curent node to each of its parent and we only do that to make the retrieval of that information easier later on, right?

What if a parent has multiple children and they all update the propagatedSecondsInQueue? What about the time the parents themselves are in queue? There might be something I don't follow to understand fully this PR

[drodriguezhdez]

You're right, it might cause unexpected behaviour. I inverted the propagation approach, checking when the current node is the initial or stage and checking if its child is an Allocate node node. Only in this case, we propagate the queue time.

This is needed because in Jenkins the queue time is calculated in this kind of nodes (Allocate node), and not in the concrete Stage/ Initial node. We need to propagate all information to the correct nodes that will be indexed in the backend.

[FlorianVeaux]

Looks good overall, there's a core concept of that PR that I'm not sure to follow though. Would you mind giving more details about what it means for a node to be "in queue", why we're propagating that to parents etc.?

[drodriguezhdez]

Sure. We consider that an item enters "in queue" when the item is "buildable" but it is waiting for some node to be scheduled to be built.

For Jenkins Build, the solution is straightforward cause there is an API to obtain the queue time directly. Unfortunately for Jenkins Pipelines, the queue time is calculated under the nodes which name is the Allocate node that will not be indexed in the backend. In this case, we need to propagate that info to its correspondent stage or initial node, which are indexed spans.