Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly validate credentials API key before using #268

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

sarah-witt
Copy link
Collaborator

What does this PR do?

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

  • Install old version of plugin
  • Enter API key as a Secret
  • Update plugin to new version
  • Ensure metrics are still submitting without user intervention

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Jan 3, 2022
@sarah-witt sarah-witt marked this pull request as ready for review January 3, 2022 16:44
@sarah-witt sarah-witt merged commit 1bf365e into master Jan 4, 2022
@sarah-witt sarah-witt deleted the sarah/fix-crendentials-logic branch January 4, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants