Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing tags when submitting service checks #30

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Fix missing tags when submitting service checks #30

merged 1 commit into from
Jan 23, 2020

Conversation

gzussa
Copy link
Contributor

@gzussa gzussa commented Jan 23, 2020 •
edited
Loading

What does this PR do?

Fix missing tags when submitting service checks
Fixes #29

Description of the Change

See changes

Verification Process

  • mvn test
  • manual test

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@gzussa gzussa added changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue severity/critical Critical severity issue labels Jan 23, 2020
@gzussa gzussa merged commit 994fd82 into master Jan 23, 2020
@gzussa gzussa deleted the gzu/sc_tags branch January 23, 2020 21:38
@everops-alex everops-alex mentioned this pull request Jan 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

@bkabrda bkabrda Awaiting requested review from bkabrda

@nmuesch nmuesch Awaiting requested review from nmuesch

@zippolyte zippolyte Awaiting requested review from zippolyte

Assignees
No one assigned
Labels
changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue severity/critical Critical severity issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service Check missing tags
2 participants
@gzussa @jirikuncar