Enforce POST in form validation #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianVeaux
previously approved these changes
May 12, 2020
src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java
Outdated
Show resolved
Hide resolved
…lConfiguration.java Co-authored-by: Florian Veaux <florian.veaux@datadoghq.com>
…lConfiguration.java Co-authored-by: Florian Veaux <florian.veaux@datadoghq.com>
FlorianVeaux
previously approved these changes
May 12, 2020
|
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
|
@sarah-witt Is that ready to be merged ? Can we rebase first also? I don't think |
|
Sure, I'll update it! |
…into sarah/enforce-post
|
Updated and tested! |
FlorianVeaux
approved these changes
Jun 22, 2020
|
|
sarah-witt
added
the
changelog/Fixed
sarah-witt
added a commit
that referenced
this pull request
Jun 22, 2020
* enforce POST in form validation * Update src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Co-authored-by: Florian Veaux <florian.veaux@datadoghq.com> * Update src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Co-authored-by: Florian Veaux <florian.veaux@datadoghq.com> * Use require post Co-authored-by: Florian Veaux <florian.veaux@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enforces post requests in form validation.
Additional Notes
Following:
https://www.jenkins.io/doc/developer/security/form-validation/
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.