Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline pause and build duration #77

Merged
merged 16 commits into from
Jun 24, 2020

Conversation

FlorianVeaux
Copy link
Contributor

@FlorianVeaux FlorianVeaux commented Jun 19, 2020

Superseding: #57 but keeping the commit history.
Fixed conflicts, improved dependencies management using the jenkins BOM

Original description:

What does this PR do?

Currently the build duration is the total time a job takes to build - including "waiting for approval". If we would use that metric to show off we would see some builds where a long build duration is shown but no one will understand that this is not only the time to build the code but also waiting steps. Therefore we want to have the possibility to also show the duration how long each job was paused.
This PR will introduce the pause duration and duration without pause duration as new metric.
I also added some log messages so that the durations are also visible in the jenkins log if the specified logger is FINE enabled.

Verification Process

I ran all tests and they are all fine
I checked the introduced log messages in my jenkins in order to verify that the timings are correct
I installed the plugin on my jenkins, ran a job and verified on datadog, that all data is there as expected

@github-actions github-actions bot added the documentation Documentation related changes label Jun 19, 2020
@FlorianVeaux FlorianVeaux mentioned this pull request Jun 19, 2020
6 tasks
@FlorianVeaux FlorianVeaux added the changelog/Added Added features results into a minor version bump label Jun 19, 2020
florimondmanca
florimondmanca previously approved these changes Jun 22, 2020
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have full context to give a definitive confident review, but approach and code LGTM 👍

Copy link
Collaborator

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
FlorianVeaux and others added 4 commits June 23, 2020 15:42
Co-authored-by: Sarah Witt <witt.s@husky.neu.edu>
Co-authored-by: Sarah Witt <witt.s@husky.neu.edu>
Copy link
Collaborator

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@FlorianVeaux FlorianVeaux merged commit f7c1465 into master Jun 24, 2020
@FlorianVeaux FlorianVeaux deleted the florian/add_pipeline_build_duration branch June 24, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Added Added features results into a minor version bump documentation Documentation related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants