-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipeline pause and build duration #77
Conversation
Reverse PR: add tests for #57 Add testing functionality for pause & checkoutduration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have full context to give a definitive confident review, but approach and code LGTM 👍
src/main/java/org/datadog/jenkins/plugins/datadog/listeners/DatadogBuildListener.java
Outdated
Show resolved
Hide resolved
src/main/java/org/datadog/jenkins/plugins/datadog/listeners/DatadogBuildListener.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Sarah Witt <witt.s@husky.neu.edu>
Co-authored-by: Sarah Witt <witt.s@husky.neu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Superseding: #57 but keeping the commit history.
Fixed conflicts, improved dependencies management using the jenkins BOM
Original description: