Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queue test to ensure metric consistency #84

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Add queue test to ensure metric consistency #84

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24dad17
Add test to check metric consistency
sarah-witt Jun 26, 2020
fd312cc
Add newline
sarah-witt Jul 6, 2020
1c48599
Comment
sarah-witt Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 50 additions & 9 deletions src/test/java/org/datadog/jenkins/plugins/datadog/publishers/DatadogQueuePublisherTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package org.datadog.jenkins.plugins.datadog.publishers;

import org.junit.BeforeClass;
import org.junit.Before;
import org.junit.ClassRule;
import org.junit.Test;
import org.jvnet.hudson.test.JenkinsRule;
Expand All @@ -17,17 +17,22 @@
import hudson.model.StringParameterValue;
import hudson.model.Cause;
import hudson.model.Computer;
import hudson.model.Queue;
import hudson.model.FreeStyleProject;
import hudson.slaves.OfflineCause;

public class DatadogQueuePublisherTest {
@ClassRule
public static JenkinsRule jenkins = new JenkinsRule();
private static DatadogClientStub client = new DatadogClientStub();
public DatadogClientStub client;
DatadogQueuePublisher queuePublisher = new DatadogQueuePublisher();

@BeforeClass
public static void setup() throws Exception {
@Before
public void setup() throws Exception {
client = new DatadogClientStub();
queuePublisher = new DatadogQueuePublisher();
ClientFactory.setTestClient(client);
jenkins.jenkins.getQueue().clear();
}

@Test
Expand All @@ -43,7 +48,6 @@ public void testQueueMetrics() throws Exception {
for (Computer computer: jenkins.jenkins.getComputers()){
computer.setTemporarilyOffline(true, OfflineCause.create(Messages._Hudson_Computer_DisplayName()));
}
DatadogQueuePublisher queuePublisher = new DatadogQueuePublisher();

final String[] expectedTags = new String[2];
expectedTags[0] = "jenkins_url:" + jenkins.getURL().toString();
Expand All @@ -69,7 +73,6 @@ public void testQueueMetricsMultipleBuilds() throws Exception {
computer.setTemporarilyOffline(true, OfflineCause.create(Messages._Hudson_Computer_DisplayName()));
}

DatadogQueuePublisher queuePublisher = new DatadogQueuePublisher();
final String[] expectedTags = new String[2];
expectedTags[0] = "jenkins_url:" + jenkins.getURL().toString();
expectedTags[1] = "job_name:" + displayName;
Expand Down Expand Up @@ -97,9 +100,7 @@ public void testQueueMetricsMultipleProjects() throws Exception {
for (Computer computer: jenkins.jenkins.getComputers()){
computer.setTemporarilyOffline(true, OfflineCause.create(Messages._Hudson_Computer_DisplayName()));
}

DatadogQueuePublisher queuePublisher = new DatadogQueuePublisher();


final String[] expectedTags = new String[2];
expectedTags[0] = "jenkins_url:" + jenkins.getURL().toString();
expectedTags[1] = "job_name:test7";
Expand Down Expand Up @@ -132,4 +133,44 @@ public void testQueueMetricsMultipleProjects() throws Exception {
client.assertMetric("jenkins.queue.job.buildable", 1, hostname, expectedTags1);
client.assertMetric("jenkins.queue.job.buildable", 1, hostname, expectedTags2);
}

@Test
public void testAllQueueMetrics() throws Exception {
String hostname = DatadogUtilities.getHostname(null);

String displayName = "";
for (int i = 0; i < 10; i++) {
FreeStyleProject project = jenkins.createFreeStyleProject();
displayName = project.getDisplayName();
project.getBuildersList().add(new SleepBuilder(10000));
project.scheduleBuild(0, new Cause.RemoteCause("host",String.valueOf(i)), new ParametersAction(new StringParameterValue("param", String.valueOf(i))));
}

// set all the computers offline so they can't execute any builds, filling up the queue
for (Computer computer: jenkins.jenkins.getComputers()){
computer.setTemporarilyOffline(true, OfflineCause.create(Messages._Hudson_Computer_DisplayName()));
}

final String[] expectedTags = new String[1];
expectedTags[0] = "jenkins_url:" + jenkins.getURL().toString();

queuePublisher.doRun();

Queue queueStats = jenkins.jenkins.getQueue();
int size = queueStats.getItems().length;
int buildable = queueStats.countBuildableItems();
int pending = queueStats.getPendingItems().size();

// Make sure values are consistent across jenkins.queue.* and jenkins.queue.job.* metrics
client.assertMetric("jenkins.queue.size", size, hostname, expectedTags);
client.assertMetricValues("jenkins.queue.job.in_queue", 1, hostname, size);

client.assertMetric("jenkins.queue.buildable", size, hostname, expectedTags);
client.assertMetricValues("jenkins.queue.job.buildable", 1, hostname, buildable);

client.assertMetric("jenkins.queue.pending", pending, hostname, expectedTags);
client.assertMetricValues("jenkins.queue.job.pending", 1, hostname, pending);
client.assertMetricValues("jenkins.queue.job.pending", 0, hostname, size);

}
}