Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more inclusive naming of config #93

Merged
merged 6 commits into from
Jul 20, 2020
Merged

Conversation

sarah-witt
Copy link
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

  • Uses more inclusive naming of config vars, introduces include/excluded config

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@github-actions github-actions bot added the documentation Documentation related changes label Jul 9, 2020
@sarah-witt sarah-witt marked this pull request as ready for review July 9, 2020 21:05
mgarabed
mgarabed previously approved these changes Jul 9, 2020
Copy link
Contributor

@mgarabed mgarabed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

mgarabed
mgarabed previously approved these changes Jul 9, 2020
@sarah-witt sarah-witt requested a review from mgarabed July 13, 2020 19:33
@sarah-witt sarah-witt merged commit f009266 into master Jul 20, 2020
@sarah-witt sarah-witt deleted the sarah/better-naming branch July 20, 2020 19:40
@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/Fixed Fixed features results into a bug fix version bump documentation Documentation related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants