JENKINS-44640 - Fix NPE checking legacy git SCM URL #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credential tracking is intended to track relevant and valuable use of the credential, not something as simple as using that credential in a form validation. Form validation is valuable for the user experience of the administrator, but it is not valuable enough to track the credential use in validating the form.
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
jglick
approved these changes
Jun 2, 2017
|
So this amends #490 IIUC? |
stephenc
approved these changes
Jun 2, 2017
| // action (like poll the repository, clone the repository, publish a change | ||
| // to the repository). | ||
| // | ||
| // CredentialsProvider.track(item, credential); |
There was a problem hiding this comment.
I'd remove this line. The comment should suffice to prevent others trying to add back
There was a problem hiding this comment.
I think I misinterpreted your "remove this line" to instead remove the entire block. I'll bring back the comment block and remove only the commented call to CredentialsProvider.track()
The comment is sufficient to explain why the implementation call is not used.
MarkEWaite
force-pushed
the
master-PRxxx-npe-passing-null-context-to-credentials
branch
from
f7fe8eb
to
f90a852
Compare
MarkEWaite
deleted the
master-PRxxx-npe-passing-null-context-to-credentials
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credential tracking is intended to track relevant and valuable use of
the credential, not something as simple as using that credential in a
form validation.
Form validation is valuable for the user experience of the
administrator, but it is not valuable enough to track the credential
use in validating the form.
Requesting @reviewbybees and by @stephenc to confirm that I've
correctly understood the vision for credential tracking.