-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose invoke
method & required interface for downstream plugins
#520
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
07ac095
Expose `invoke` method & required interface for downstream plugins to…
kzantow 54270ab
Add javadocs
kzantow 6ff7567
Javadoc issue
kzantow 827192b
Moar Javadoc
kzantow 8b9e066
Remove @Override from javadoc example
kzantow 07fa6e1
Reduce indentation
kzantow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -147,7 +147,41 @@ public SCMFile getRoot() { | |
return commitId; | ||
} | ||
|
||
/*package*/ <V> V invoke(final FSFunction<V> function) throws IOException, InterruptedException { | ||
/** | ||
* Called with an {@link FSFunction} callback with a singleton repository | ||
* cache lock. | ||
* | ||
* An example usage might be: | ||
* | ||
* <pre> | ||
* {@code | ||
* return fs.invoke(new GitSCMFileSystem.FSFunction<byte[]>() { | ||
* @Override | ||
* public byte[] invoke(Repository repository) throws IOException, InterruptedException { | ||
* Git activeRepo = getClonedRepository(repository); | ||
* File repoDir = activeRepo.getRepository().getDirectory().getParentFile(); | ||
* System.out.println("Repo cloned to: " + repoDir.getCanonicalPath()); | ||
* try { | ||
* File f = new File(repoDir, filePath); | ||
* if (f.canRead()) { | ||
* return IOUtils.toByteArray(new FileInputStream(f)); | ||
* } | ||
* return null; | ||
* } finally { | ||
* FileUtils.deleteDirectory(repoDir); | ||
* } | ||
* } | ||
* }); | ||
* } | ||
* </pre> | ||
* | ||
* @param <V> return type | ||
* @param function callback executed with a locked repository | ||
* @return whatever you return from the provided function | ||
* @throws IOException if there is an I/O error | ||
* @throws InterruptedException if interrupted | ||
*/ | ||
public <V> V invoke(final FSFunction<V> function) throws IOException, InterruptedException { | ||
Lock cacheLock = AbstractGitSCMSource.getCacheLock(cacheEntry); | ||
cacheLock.lock(); | ||
try { | ||
|
@@ -211,7 +245,16 @@ public boolean changesSince(@CheckForNull SCMRevision revision, @NonNull OutputS | |
} | ||
} | ||
|
||
/*package*/ interface FSFunction<V> { | ||
/** | ||
* Simple callback that is used with | ||
* {@link #invoke(jenkins.plugins.git.GitSCMFileSystem.FSFunction)} | ||
* in order to provide a locked view of the Git repository | ||
*/ | ||
public interface FSFunction<V> { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If making public we should provide clear guidelines in javadocs |
||
/** | ||
* Called with a lock on the repository in order to perform some | ||
* operations that might result in changes and necessary re-indexing | ||
*/ | ||
V invoke(Repository repository) throws IOException, InterruptedException; | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadocs