[FIXED JENKINS-48064] Fisheye Git browser now validates its URL in th… #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
approved these changes
Nov 20, 2017
There was a problem hiding this comment.
I used an interactive test to confirm the check is now called.
Will need more work later to create an automated test (and to fix the other checkers which are not being called). When I was working on the "Intro to Plugin Development" workshop for Jenkins World 2017, I realized it should be possible to create automated tests of FormValidation checkers, but I didn't have time to create a sample test at that time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e configuration.
Simply restores the binding between the page view and the check method.